Delete TODOs we're never going to fix #3197

benchristel · 2026-01-22T23:54:26Z

Some of these TODOs represent the wishful thinking of our forebears a decade
ago. Others have become obsolete as code changed around them. I'd like to be
able to grep for TODO in our codebase and get a sense of where the real tech
debt is, and having old, won't-fix TODOs makes that difficult.

If any of the removed TODOs are truly important, I trust they'll come back.

Issue: none

Test plan:

none

github-actions · 2026-01-22T23:55:18Z

🗄️ Schema Change: No Changes ✅

github-actions · 2026-01-22T23:55:43Z

🛠️ Item Splitting: No Changes ✅

github-actions · 2026-01-22T23:55:59Z

Size Change: 0 B

Total Size: 485 kB

ℹ️ View Unchanged

Filename	Size
`packages/kas/dist/es/index.js`	20.8 kB
`packages/keypad-context/dist/es/index.js`	1 kB
`packages/kmath/dist/es/index.js`	5.98 kB
`packages/math-input/dist/es/index.js`	98.5 kB
`packages/math-input/dist/es/strings.js`	1.61 kB
`packages/perseus-core/dist/es/index.item-splitting.js`	11.8 kB
`packages/perseus-core/dist/es/index.js`	24.8 kB
`packages/perseus-editor/dist/es/index.js`	99.2 kB
`packages/perseus-linter/dist/es/index.js`	8.83 kB
`packages/perseus-score/dist/es/index.js`	9.32 kB
`packages/perseus-utils/dist/es/index.js`	403 B
`packages/perseus/dist/es/index.js`	187 kB
`packages/perseus/dist/es/strings.js`	7.44 kB
`packages/pure-markdown/dist/es/index.js`	1.39 kB
`packages/simple-markdown/dist/es/index.js`	6.71 kB

_{compressed-size-action}

github-actions · 2026-01-22T23:56:37Z

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (8dc0a8d) and published it to npm. You
can install it using the tag PR3197.

Example:

pnpm add @khanacademy/perseus@PR3197

If you are working in Khan Academy's frontend, you can run the below command.

./dev/tools/bump_perseus_version.ts -t PR3197

If you are working in Khan Academy's webapp, you can run the below command.

./dev/tools/bump_perseus_version.js -t PR3197

benchristel · 2026-02-02T19:21:48Z

packages/perseus-core/src/types.ts

    /**
     * @deprecated - do not use in new code.
     */
-    getSerializedState(): State;


getSerializedState is deprecated; hence, we're never going to type this.

benchristel · 2026-02-02T19:22:01Z

packages/perseus-editor/src/__docs__/editor.stories.tsx

                            showWordCount={true}
                            warnNoPrompt={false}
                            warnNoWidgets={true}
-                            // TODO(LEMS-2656): remove TS suppression


There is no TS suppression here.

benchristel · 2026-02-02T19:34:08Z

packages/perseus-editor/src/widgets/interaction-editor/interaction-editor.tsx

-            // TODO(eater): The 22nd function added will be {(x) since '{'
-            // comes after 'z'


This is a funny bug, but the interaction widget is very dead, so we are never going to fix it.

benchristel · 2026-02-02T19:35:12Z

packages/perseus-editor/src/widgets/label-image-editor/answer-choices.tsx

 /**
 * An answer item in the choices list.
- *
- * TODO(michaelpolyak): Implement answer reordering, CP-117


CP-117 has been marked Won't Do.

Also, I think our label-image widget editor supports re-ordering by dragging.

benchristel · 2026-02-02T19:36:05Z

packages/perseus-editor/src/widgets/label-image-editor/select-image.tsx

-                // it can be triggered from within the widget, or requires
-                // a similar implementation locally, in which case consider
-                // refactoring `perseus-admin-package/image-upload-dialog.jsx`
-                // as common utility, CP-118


CP-118 has been marked Won't Do.

benchristel · 2026-02-02T19:36:48Z

packages/perseus-editor/src/widgets/molecule-editor.tsx

Molecule is a dead widget.

benchristel · 2026-02-02T19:45:29Z

packages/perseus/src/widgets/plotter/plotter.tsx

-        // TODO(kevinb) actually compute the size of the graphie correctly and
-        // make it that size so we don't have to add extra padding.  The value
-        // was determined by eye-balling the layout.  :(
        const paddingForBottomLabel = 75;


This is a gross hack, but plotter is deprecated and hidden from the widget dropdown in the editors, so it's probably not worth fixing.

jeremywiebe · 2026-02-02T22:25:50Z

packages/perseus-core/src/data-schema.ts

 // be independent of everything else.
 import type {KeypadKey} from "./keypad";

-// TODO(FEI-4010): Remove `Perseus` prefix for all types here


commentary Hm. This ticket was closed as Won't Do, but I think it's still a valuable thing. React doesn't prefix its symbols with ReactXyz (typically) and we could shorten alot of our types by removing the prefix. That said, probably a very low-value set of work.

TLDR: I'm good with removing this TODO. :)

jeremywiebe · 2026-02-02T22:27:58Z

packages/perseus-editor/src/widgets/interaction-editor/arrow-picker.tsx

                    {value: "", content: <span>&mdash;</span>},
                    {value: "->", content: <span>&#x2192;</span>},
-                    /*
-                TODO(eater): fix khan-exercises so these are supported


khan-exercises?? 😂 That's a while ago

jeremywiebe · 2026-02-02T22:29:56Z

packages/perseus-editor/src/widgets/label-image-editor/answer-choices.tsx

 /**
 * An answer item in the choices list.
- *
- * TODO(michaelpolyak): Implement answer reordering, CP-117


Also, I think our label-image widget editor supports re-ordering by dragging.

jeremywiebe · 2026-02-02T22:35:31Z

packages/perseus/src/styles/widgets/categorizer.css


-/* TODO(benkomalo): ughhh. kill or move this out of here :(
-   Styles specifically for the mobile native apps */
+/* Styles specifically for the mobile native apps */


I wonder ... if this is used now that mobile uses the web experience. 🤔 No change necessary on this PR, but can this be removed entirelY?

benchristel self-assigned this Jan 22, 2026

benchristel added the olc-5.0.07850 label Jan 22, 2026

benchristel added 5 commits February 2, 2026 10:22

[benc/delete-old-todos] Delete TODOs

6491114

[benc/delete-old-todos] Delete more TODOs

c0d2532

[benc/delete-old-todos] Delete TODOs

d29b5a2

[benc/delete-old-todos] Delete more TODOs

be09b79

[benc/delete-old-todos] Delete more TODOs

2d6edf0

benchristel force-pushed the benc/delete-old-todos branch from cfcd6de to 2d6edf0 Compare February 2, 2026 18:25

[benc/delete-old-todos] docs(changeset):

dfe1cfb

benchristel marked this pull request as ready for review February 2, 2026 18:25

benchristel requested review from catandthemachines and jeremywiebe February 2, 2026 18:25

benchristel commented Feb 2, 2026

View reviewed changes

[benc/delete-old-todos] Restore comment

8dc0a8d

benchristel commented Feb 2, 2026

View reviewed changes

packages/perseus-editor/src/widgets/molecule-editor.tsx

Copy link

Member Author

benchristel Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Molecule is a dead widget.

benchristel commented Feb 2, 2026

View reviewed changes

jeremywiebe approved these changes Feb 2, 2026

View reviewed changes

benchristel changed the title ~~Delete TODOs we're never going to fix~~ Delete TODOs we're never going to fix - Feb 2, 2026

benchristel changed the title ~~Delete TODOs we're never going to fix -~~ Delete TODOs we're never going to fix Feb 2, 2026

benchristel merged commit 7fcef1a into main Feb 3, 2026
11 of 25 checks passed

benchristel deleted the benc/delete-old-todos branch February 3, 2026 16:02

		// TODO(eater): The 22nd function added will be {(x) since '{'
		// comes after 'z'

Delete TODOs we're never going to fix #3197

Delete TODOs we're never going to fix #3197

Uh oh!

Conversation

benchristel commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test plan:

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🗄️ Schema Change: No Changes ✅

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛠️ Item Splitting: No Changes ✅

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

npm Snapshot: Published

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

benchristel commented Jan 22, 2026 •

edited

Loading

github-actions bot commented Jan 22, 2026 •

edited

Loading

github-actions bot commented Jan 22, 2026 •

edited

Loading

github-actions bot commented Jan 22, 2026 •

edited

Loading

github-actions bot commented Jan 22, 2026 •

edited

Loading